feat: manage download articles entirely in Markdown

This commit is contained in:
2026-11-02 11:15:23 +08:00
parent bbe0aaf88e
commit bcc32d9626
9 changed files with 100 additions and 58 deletions
+51 -11
View File
@@ -4,6 +4,7 @@ import (
"encoding/json"
"path/filepath"
"reflect"
"strings"
"testing"
)
@@ -31,7 +32,7 @@ func TestDownloadCatalogLegacyCompatibilityAndPersistence(t *testing.T) {
t.Fatal(err)
}
items := public.Site.Downloads
if len(items) != 2 || items[0].Name != "Ubuntu" || len(items[0].Files) != 2 || items[0].Files[1].Label != "24.04 (arm64)" || items[1].Files[0].Label != "Tool" || items[0].Category != "software" || !validName(items[0].ID) || items[0].URL != "" {
if len(items) != 2 || items[0].Name != "Ubuntu" || len(items[0].Files) != 0 || !strings.Contains(items[0].Description, "[24.04 (arm64)](<https://example.invalid/ubuntu-arm.iso>)") || !strings.Contains(items[0].Description, "[24.04 (amd64)](<https://example.invalid/ubuntu.iso>)") || !strings.Contains(items[1].Description, "[Tool](<https://example.invalid/tool.zip>)") || items[0].Category != "software" || !validName(items[0].ID) || items[0].URL != "" {
t.Fatalf("legacy projects or version links lost: %+v", items)
}
c.app.db.QueryRow("SELECT data FROM records WHERE kind='settings' AND id='site'").Scan(&rawAfter)
@@ -49,9 +50,8 @@ func TestDownloadCatalogLegacyCompatibilityAndPersistence(t *testing.T) {
t.Fatal("older form lost downloads or changed stable project IDs")
}
settings.Downloads[0].Category = "os"
settings.Downloads[0].Description = "## Ubuntu\n\n选择适合设备架构的版本。"
settings.Downloads[0].Files[0].URL = "/mirrors/ubuntu-releases/24.04/ubuntu.iso"
settings.Downloads = append(settings.Downloads, Download{ID: "fonts", Name: "字体", Category: "fonts", Files: []DownloadFile{{Label: "字体压缩包", URL: "https://example.invalid/font.zip"}}})
settings.Downloads[0].Description = "## Ubuntu\n\n[24.04 (amd64)](/mirrors/ubuntu-releases/24.04/ubuntu.iso)\n\nSHA256: `0123456789abcdef`"
settings.Downloads = append(settings.Downloads, Download{ID: "fonts", Name: "字体", Category: "fonts", Description: "字体的安装方法。"})
w = c.call("PUT", "/api/v1/admin/records/settings/site", map[string]any{"data": settings, "revision": saved.Revision}, true)
status(t, w, 200)
status(t, c.call("PUT", "/api/v1/admin/records/settings/site", map[string]any{"data": settings, "revision": saved.Revision}, true), 409)
@@ -87,19 +87,19 @@ func TestDownloadCatalogValidationAndPermissions(t *testing.T) {
c := fixture(t)
c.login("admin")
record, _ := c.app.record("settings", "site")
base := Download{ID: "ubuntu", Name: "Ubuntu", Category: "os", Files: []DownloadFile{{Label: "24.04 LTS (amd64)", URL: "/mirrors/ubuntu-releases/24.04/ubuntu.iso"}}}
base := Download{ID: "ubuntu", Name: "Ubuntu", Category: "os", Description: "## Ubuntu\n\n[24.04 LTS (amd64)](/mirrors/ubuntu-releases/24.04/ubuntu.iso)"}
mutations := []func(*Download){
func(d *Download) { d.ID = "" },
func(d *Download) { d.Category = "unknown" },
func(d *Download) { d.Name = " " },
func(d *Download) { d.Files = nil },
func(d *Download) { d.Files[0].Label = " " },
func(d *Download) { d.Files[0].URL = "javascript:alert(1)" },
func(d *Download) { d.Files[0].URL = "//example.invalid/a.iso" },
func(d *Download) { d.Files[0].URL = "/\\example.invalid/a.iso" },
func(d *Download) { d.Files[0].URL = "https://user:password@example.invalid/a.iso" },
func(d *Download) { d.Description = " \n\t" },
func(d *Download) { d.Description = strings.Repeat("a", 100001) },
func(d *Download) { d.Files = []DownloadFile{{Label: " ", URL: "/mirrors/a.iso"}} },
func(d *Download) { d.URL = "https://example.invalid/ambiguous-old-field" },
}
for _, url := range []string{"javascript:alert(1)", "//example.invalid/a.iso", "/\\example.invalid/a.iso", "https://user:password@example.invalid/a.iso"} {
mutations = append(mutations, func(d *Download) { d.Files = []DownloadFile{{Label: "ISO", URL: url}} })
}
for index, mutate := range mutations {
var item Download
decodeData(base, &item)
@@ -115,6 +115,46 @@ func TestDownloadCatalogValidationAndPermissions(t *testing.T) {
settings.Downloads = []Download{base, base}
status(t, c.call("PUT", "/api/v1/admin/records/settings/site", map[string]any{"data": settings, "revision": record.Revision}, true), 400)
settings.Downloads = []Download{base}
status(t, c.call("PUT", "/api/v1/admin/records/settings/site", map[string]any{"data": settings, "revision": record.Revision}, true), 200)
c.login("editor")
status(t, c.call("PUT", "/api/v1/admin/records/settings/site", map[string]any{"data": settings, "revision": record.Revision}, true), 403)
}
func TestDownloadArticlesPreserveExistingMarkdownAndLinksOnce(t *testing.T) {
body := "## Debian 13\n\n版本、签名与 SHA256:`abc123`。\n\n[签名](/mirrors/debian-cd/SHA256SUMS.sign)"
input := []Download{{ID: "debian", Name: "Debian", Category: "os", Description: body, Files: []DownloadFile{
{Label: "ISO [amd64] <mirror>", URL: "/mirrors/debian-cd/image (amd64).iso?source=<mirror>"},
{Label: "SHA256SUMS", URL: "https://example.invalid/SHA256SUMS"},
}}}
articles := normalizeDownloads(input)
if len(articles[0].Files) != 0 || !validDownloads(articles) || !strings.HasPrefix(articles[0].Description, body+"\n\n") {
t.Fatal("existing article or legacy links were lost")
}
for _, link := range []string{
"- [ISO \\[amd64\\] &lt;mirror&gt;](</mirrors/debian-cd/image%20(amd64).iso?source=%3Cmirror%3E>)",
"- [SHA256SUMS](<https://example.invalid/SHA256SUMS>)",
} {
if !strings.Contains(articles[0].Description, link) {
t.Fatalf("legacy link not safely preserved: %s", articles[0].Description)
}
}
if !reflect.DeepEqual(normalizeDownloads(articles), articles) || len(input[0].Files) != 2 || input[0].Description != body {
t.Fatal("normalization duplicated links or mutated the input")
}
raw, _ := json.Marshal(articles)
if strings.Contains(string(raw), `"files"`) {
t.Fatal("article response still exposes a separate download-link module")
}
}
func TestDownloadArticlesReuseLinksAlreadyInMarkdown(t *testing.T) {
body := "## 下载\n\n[ISO](/mirrors/debian/image.iso)\n\n[签名](<https://example.invalid/image.iso.sig>)"
input := []Download{{ID: "debian", Name: "Debian", Category: "os", Description: body, Files: []DownloadFile{
{Label: "安装镜像", URL: "/mirrors/debian/image.iso"},
{Label: "签名", URL: "https://example.invalid/image.iso.sig"},
}}}
output := normalizeDownloads(input)
if !validDownloads(output) || output[0].Description != body || len(output[0].Files) != 0 {
t.Fatal("migration duplicated links already maintained in the article")
}
}